[wp-trac] [WordPress Trac] #13091: edit_post action on wp_update_comment_count_now should not be fired if the comment count hasn't changed

WordPress Trac wp-trac at lists.automattic.com
Fri May 14 06:34:52 UTC 2010


#13091: edit_post action on wp_update_comment_count_now should not be fired if the
comment count hasn't changed
--------------------------+-------------------------------------------------
 Reporter:  solarissmoke  |       Owner:                        
     Type:  defect (bug)  |      Status:  new                   
 Priority:  normal        |   Milestone:  Future Release        
Component:  Comments      |     Version:  3.0                   
 Severity:  normal        |    Keywords:  dev-feedback has-patch
--------------------------+-------------------------------------------------

Comment(by solarissmoke):

 Okay, let me try to explain my point of view:

 Currently, all other calls for edit_post (in wp_insert_post() and
 wp_publish_post() ) are when post content has changed.

 There are many instances where you might want to know when a post has
 visibly changed (e.g., post content or approved comments have changed) -
 for example for email notifications or cache invalidation. But you would
 not want to trigger such events if the change does not affect what is
 visible on the site (e.g., a spam comment was trashed).

 If edit_post isn't mean to reflect visible changes to a post, perhaps we
 might introduce a new action that is? -- "post_changed", or something like
 that?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13091#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list