[wp-trac] [WordPress Trac] #12334: A series of typos/thinkos that should be fixed

[WordPress Trac]

#12334: A series of typos/thinkos that should be fixed
--------------------------+-------------------------------------------------
 Reporter:  rlerdorf      |        Owner:  nacin 
     Type:  defect (bug)  |       Status:  closed
 Priority:  low           |    Milestone:  3.0   
Component:  General       |      Version:        
 Severity:  normal        |   Resolution:  fixed 
 Keywords:                |  
--------------------------+-------------------------------------------------

Old description:

> In wp-includes/capabilities.php around line 773:
>
> $cap_key = $wpdb->get_blog_prefix( $blog_id );
> $cap_key. 'capabilities';
>
> The author probably meant .= here.
>
> In wp-admin/import/blogger.php around line 168:
>
> } elseif ( $tag['tag'] == 'SUMMARY' ) {
>         $blog['summary'] == $tag['value'];
>
> The == on the second line there should obviously be just a single =
>
> In wp-admin/includes/user.php around line 835:
>
> function default_password_nag_edit_user($user_ID, $old_data) {
>         global $user_ID;
>
> The author overwrites the passed in $user_ID argument with the global
> version right away.  This makes very little sense.  Choose one or the
> other.
>
> In wp-includes/class-simplepie.php around line 4070(!!) there are 3 lines
> of code that don't make sense:
>
> (int) $seconds = array_pop($temp);
> (int) $minutes = array_pop($temp);
> (int) $hours = array_pop($temp);
>
> Those casts don't do anything.  The author probably meant to put the cast
> on the right hand side perhaps?

New description:

 In wp-includes/capabilities.php around line 773:
 {{{
 $cap_key = $wpdb->get_blog_prefix( $blog_id );
 $cap_key. 'capabilities';
 }}}
 The author probably meant .= here.

 In wp-admin/import/blogger.php around line 168:
 {{{
 } elseif ( $tag['tag'] == 'SUMMARY' ) {
         $blog['summary'] == $tag['value'];
 }}}
 The == on the second line there should obviously be just a single =

 In wp-admin/includes/user.php around line 835:
 {{{
 function default_password_nag_edit_user($user_ID, $old_data) {
         global $user_ID;
 }}}
 The author overwrites the passed in $user_ID argument with the global
 version right away.  This makes very little sense.  Choose one or the
 other.

 In wp-includes/class-simplepie.php around line 4070(!!) there are 3 lines
 of code that don't make sense:
 {{{
 (int) $seconds = array_pop($temp);
 (int) $minutes = array_pop($temp);
 (int) $hours = array_pop($temp);
 }}}
 Those casts don't do anything.  The author probably meant to put the cast
 on the right hand side perhaps?

--

Comment(by westi):

 Fix the formatting :-)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12334#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software