[wp-trac] [WordPress Trac] #13317: Code Impriovement in get_userdata

WordPress Trac wp-trac at lists.automattic.com
Wed May 12 06:49:58 UTC 2010

#13317: Code Impriovement in get_userdata
 Reporter:  hakre         |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  lowest        |   Milestone:  3.0      
Component:  General       |     Version:           
 Severity:  normal        |    Keywords:  has-patch

Comment(by hakre):

 I finally must admit that those useless comments might have distracted me
 somehow and in kind of a bad influence.

 Naturally my original patch is totally okay and nacin's suggestion to it
 are infact silly.

 It's common practice in core code when it comes to a comparison against
 zero for a userid to do it with the numerical value and the standard php
 comparison operator {{{==}}}. Using {{{false}}} or {{{!}}} would be

 So my new choice is A.

 I hope some other comitter is able to concentrate on the actual work
 instead of trying to find an argumentation to no do things. It's
 especially a problem for me to see a really useless discussion here
 instead of a quick and straight ticket handling. It's not me who is
 wasting time in the end. Please deal with such minor changes more
 efficient next time to safe us all some time to concentrate on more
 important stuff. Thanks.

Ticket URL: <http://core.trac.wordpress.org/ticket/13317#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list