[wp-trac] [WordPress Trac] #13163: Incorrect POP3 error messages in wp-mail.php

[WordPress Trac]

#13163: Incorrect POP3 error messages in wp-mail.php
---------------------------+------------------------------------------------
 Reporter:  solarissmoke   |       Owner:  westi         
     Type:  defect (bug)   |      Status:  new           
 Priority:  normal         |   Milestone:  Future Release
Component:  Blog by Email  |     Version:  3.0           
 Severity:  normal         |    Keywords:  has-patch     
---------------------------+------------------------------------------------

Comment(by solarissmoke):

 Replying to [comment:3 nacin]:
 > I don't understand that part. Once we hit false (connection, user, pass,
 in that order), we would break into the if statement and spit out the
 error. So we would never evaluate the user if we don't have a connection.

 The error-spitting bit checks for $count === 0 before deciding what to
 output. Problem is, we manually set $count to 0 beforehand. And it won't
 change unless the last of the three of (connection, user, pass) is
 reached. Which it won't be if connection/user fails. So if connection/user
 fails, you still get the message "there doesn't appear to be any new
 mail".

 So we need to do connection/user first, make sure there was no error, and
 then do the password.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13163#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software