[wp-trac] [WordPress Trac] #12732: Bulk Actions needs to allow custom bulk actions

WordPress Trac wp-trac at lists.automattic.com
Tue May 4 20:09:16 UTC 2010


#12732: Bulk Actions needs to allow custom bulk actions
----------------------------+-----------------------------------------------
 Reporter:  ptahdunbar      |       Owner:           
     Type:  enhancement     |      Status:  new      
 Priority:  normal          |   Milestone:  3.0      
Component:  Administration  |     Version:  3.0      
 Severity:  normal          |    Keywords:  has-patch
----------------------------+-----------------------------------------------

Comment(by TobiasBg):

 I really like that one.

 A few things I noticed when glancing over the patch:

 - in edit-comments.php, the filter shall probably be called "bulk_actions-
 comments" and not "bulk_actions-users" (probably leftover from copy&paste)

 - I suggest proper initialisation of each $bulk_actions array, i.e.
 $bulk_actions = array(); before each one is used the first time. (Although
 each one seems to have the ['-1'] entry, I believe that that is better
 practice.)

 - Your tab width seems to be pretty long (like 8 spaces). Or is it just
 the Trac view of the patch? But maybe the commiter could/would clean that
 up anyway.

 Thanks for the patch!

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12732#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list