[wp-trac] [WordPress Trac] #12735: get_blogaddress_by_* adds path in multisite. breaks get_home_url etc

[WordPress Trac]

#12735: get_blogaddress_by_* adds path in multisite. breaks get_home_url etc
--------------------------+-------------------------------------------------
 Reporter:  andreasnrb    |       Owner:     
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.0
Component:  Multisite     |     Version:  3.0
 Severity:  critical      |    Keywords:     
--------------------------+-------------------------------------------------

Comment(by andreasnrb):

 Replying to [comment:4 ryan]:
 > Line 71 of my-sites.php should use admin_url().  homeurl and siteurl in
 blog details seem pretty useless. We should almost always go through the
 *_url() functions to get those.  Likewise, $current_site really doesn't
 need homeurl and siteurl.  Just set site_path and let the network_url() do
 the piecing together. That way there a not multiple means of accessing the
 same thing.
 my-sites cant use admin_url since that is for a single blog. if anything
 it should be get_admin_url and get_home_url but that just adds another
 function call to get the same info that really belongs to blogdetails.
 Siteurl in blogdetails wasnt added by me so don't think we can remove it.
 The blogdetails really should be loaded in one big swoop instead of
 individual calls like it is now.

 Saw some bugs in my patch that I'll fix tomorrow.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12735#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software