[wp-trac] [WordPress Trac] #12519: wp_unregister_GLOBALS violates with specs

WordPress Trac wp-trac at lists.automattic.com
Sat Mar 6 04:59:06 UTC 2010


#12519: wp_unregister_GLOBALS violates with specs
------------------------------+---------------------------------------------
 Reporter:  hakre             |        Owner:          
     Type:  defect (bug)      |       Status:  reopened
 Priority:  lowest            |    Milestone:          
Component:  General           |      Version:  3.0     
 Severity:  trivial           |   Resolution:          
 Keywords:  has-patch tested  |  
------------------------------+---------------------------------------------
Changes (by hakre):

  * status:  closed => reopened
  * resolution:  wontfix =>


Comment:

 Your argument is not very convincing, the meaning of the function does not
 depend on case here.

 This should have propper reasons, the
 [http://codex.wordpress.org/WordPress_Coding_Standards coding standard] is
 very clear about how functions have to be written:

 '''Variables, functions, file names, and operators'''
 Use lowercase letters in variable and function names (never camelcase).
 Separate words via underscores

 Since this function is even called internally (in a single point of
 invoke!), I'll extend the patch to reflect that.

 Please rething your argumentation.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12519#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list