[wp-trac] [WordPress Trac] #12452: Wrong comments feed link advertised with static front page (was: Wrong feed links advertised with static front page)

[WordPress Trac]

#12452: Wrong comments feed link advertised with static front page
--------------------------+-------------------------------------------------
 Reporter:  mdgl          |       Owner:             
     Type:  defect (bug)  |      Status:  new        
 Priority:  normal        |   Milestone:  3.0        
Component:  Feeds         |     Version:  2.9.2      
 Severity:  normal        |    Keywords:  needs-patch
--------------------------+-------------------------------------------------
Changes (by Denis-de-Bernardy):

  * keywords:  2nd-opinion => needs-patch
  * type:  enhancement => defect (bug)
  * milestone:  Future Release => 3.0


Old description:

> When a static front page is configured (e.g. for a CMS site), the wrong
> feed links are advertised since the URL for the "page comments" feed
> conflicts with the default feed URL.
>
> Consider the following configuration:
>
>    Front page: "Home" (http://www.site.com/)
>
>    Blog home:  "Blog" (http://www.site.com/blog)
>
>    Permalinks: "/blog/%year%/%monthnum%/%postname%/"
>
> By default (core, no theme), the front page then advertises a "Home
> Comments Feed" for the URL "http://www.site.com/feed/" but in fact this
> returns the feed for the site blog (default feed), not the comments on
> the "Home" page as stated.  No feed is advertised from the blog home page
> at all.
>
> Enabling the extra feed links using "automatic_feed_links()" in the theme
> (as happens with Kubrick, for example) causes two additional feeds to be
> advertised from *every* page of the site (for site blog and comments).
> The front page then advertises three feed links "Feed", "Comments Feed"
> and "Home Comments Feed" which return the site blog, site comments and
> (duplicate/incorrect) site blog feeds respectively.
>
> I believe the following behaviour should be observed:
>
> a) Default feeds should move to wherever the blog home is set (e.g.
> http://www.site.com/blog/feed, http://www.site.com/blog/comments/feed).
>
> b) Automatic links to the site blog and site comments should *not* be
> added to every page, because these are not really "alternate" versions of
> the page being viewed as the link headers so claim (we should preserve
> the semantics of HTML where possible). Agreed the core does not do this,
> but the default theme Kubrick does.
>
> c) Ideally, feeds for the whole site should be distinguished from those
> for the blog (i.e. not including changes and comments to pages in the
> blog feed), but that is probably a rather larger issue!

New description:

 A static's front page's comments feed is:

 example.com/page-slug/feed/

 But automatic_feed_links() advertises it as:

 example.com/feed/

 ---

 Was:

 ---

 When a static front page is configured (e.g. for a CMS site), the wrong
 feed links are advertised since the URL for the "page comments" feed
 conflicts with the default feed URL.

 Consider the following configuration:

    Front page: "Home" (http://www.site.com/)

    Blog home:  "Blog" (http://www.site.com/blog)

    Permalinks: "/blog/%year%/%monthnum%/%postname%/"

 By default (core, no theme), the front page then advertises a "Home
 Comments Feed" for the URL "http://www.site.com/feed/" but in fact this
 returns the feed for the site blog (default feed), not the comments on the
 "Home" page as stated.  No feed is advertised from the blog home page at
 all.

 Enabling the extra feed links using "automatic_feed_links()" in the theme
 (as happens with Kubrick, for example) causes two additional feeds to be
 advertised from *every* page of the site (for site blog and comments). The
 front page then advertises three feed links "Feed", "Comments Feed" and
 "Home Comments Feed" which return the site blog, site comments and
 (duplicate/incorrect) site blog feeds respectively.

 I believe the following behaviour should be observed:

 a) Default feeds should move to wherever the blog home is set (e.g.
 http://www.site.com/blog/feed, http://www.site.com/blog/comments/feed).

 b) Automatic links to the site blog and site comments should *not* be
 added to every page, because these are not really "alternate" versions of
 the page being viewed as the link headers so claim (we should preserve the
 semantics of HTML where possible). Agreed the core does not do this, but
 the default theme Kubrick does.

 c) Ideally, feeds for the whole site should be distinguished from those
 for the blog (i.e. not including changes and comments to pages in the blog
 feed), but that is probably a rather larger issue!

--

Comment:

 oh, ok. that makes more sense. changing the ticket's title and amending
 the description slightly, then.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12452#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software