[wp-trac] [WordPress Trac] #13939: get_page_of_comment returns wrong page number when changing threading level

WordPress Trac wp-trac at lists.automattic.com
Thu Jun 17 10:58:28 UTC 2010


#13939: get_page_of_comment returns wrong page number when changing threading level
--------------------------+-------------------------------------------------
 Reporter:  laceous       |       Owner:                         
     Type:  defect (bug)  |      Status:  new                    
 Priority:  normal        |   Milestone:  3.1                    
Component:  Comments      |     Version:  3.0                    
 Severity:  normal        |    Keywords:  has-patch needs-testing
--------------------------+-------------------------------------------------
Changes (by nacin):

  * milestone:  3.0.1 => 3.1


Comment:

 get_query_var('comments_per_page') is handled in WP_Query like so:
 {{{
                 if ( !isset($q['comments_per_page']) ||
 $q['comments_per_page'] == 0 )
                         $q['comments_per_page'] =
 get_option('comments_per_page');
 }}}

 Moving back to 3.1, as this isn't major or a regression.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13939#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list