[wp-trac] [WordPress Trac] #13880: Custom Header Image Upload Bug

WordPress Trac wp-trac at lists.automattic.com
Mon Jun 14 07:01:35 UTC 2010


#13880: Custom Header Image Upload Bug
--------------------------+-------------------------------------------------
 Reporter:  CAMWebDesign  |       Owner:  ocean90    
     Type:  defect (bug)  |      Status:  assigned   
 Priority:  high          |   Milestone:  3.0        
Component:  Upload        |     Version:  3.0        
 Severity:  normal        |    Keywords:  needs-patch
--------------------------+-------------------------------------------------

Comment(by nacin):

 I think part of the problem here is that we're doing processing in
 ::admin_page() instead of before anything has been sent, which would be a
 lot easier in terms of processing data then deciding what should be
 rendered, which would allow for a redirect, a proper wp_die(), or
 conditionally printing javascript, etc.

 Your fix seems fine for 3.0, and we can improve the architecture in a
 future release. If you want to learn how to create a patch, take a look at
 http://core.trac.wordpress.org/#HowtoSubmitPatches.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13880#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list