[wp-trac] [WordPress Trac] #11644: multiple blogs & sites / merge WPMU

WordPress Trac wp-trac at lists.automattic.com
Thu Jan 28 20:05:10 UTC 2010

#11644: multiple blogs & sites / merge WPMU
 Reporter:  hakre           |       Owner:  wpmuguru 
     Type:  task (blessed)  |      Status:  assigned 
 Priority:  normal          |   Milestone:  3.0      
Component:  Multisite       |     Version:           
 Severity:  normal          |    Keywords:  multisite

Comment(by nacin):

 [attachment:11644.8.diff] cleans up ms-settings.php and removes some
 redundant code.

 The $PHP_SELF chunk is odd logic that had existed in MU:
 ( empty($PHP_SELF) || ( empty($PHP_SELF) && !is_subdomain_install() &&
 $current_blog->path != '/' ) )
 The corresponding WordPress code (see wp_fix_server_vars() in load.php)
 simply checks for {{{empty($PHP_SELF)}}}. Since $PHP_SELF is checked in
 MU/MS on both sides of this OR, it doesn't do anything. (I checked, and it
 was originally committed to MU this way.)

 Likewise, there's an empty if statement for {{{0 ==
 $current_blog->public}}}, also committed that way to MU years ago.

 Finally, there's an if statement that goes like this:
 if ( something )
    $blog_id = 1;
    $blog_id = 1;

 I've cleaned up some other bits as well.

Ticket URL: <http://core.trac.wordpress.org/ticket/11644#comment:125>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list