[wp-trac] [WordPress Trac] #11542: Add "Upgrade" to bulk actions on plugins.php

WordPress Trac wp-trac at lists.automattic.com
Tue Jan 26 06:45:14 UTC 2010


#11542: Add "Upgrade" to bulk actions on plugins.php
--------------------------+-------------------------------------------------
 Reporter:  janeforshort  |       Owner:  nacin    
     Type:  enhancement   |      Status:  accepted 
 Priority:  normal        |   Milestone:  3.0      
Component:  Plugins       |     Version:  2.9      
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by nacin):

 [attachment:11542.2.diff] has a few improvements.

 If no out of date plugins are selected, then the plugins page is again
 shown and a message is displayed. It also doesn't include the wp-upgrader
 class before it needs to, does some cap checks, and moves over to site
 transients.

 If you check two plugins, only one of which is out of date, and you
 attempt a bulk upgrade, it takes you to the upgrader and say it is
 upgrading 2 plugins. If as the original patch suggested we do not pass
 those plugins along, you don't get that proper feedback (and instead, you
 checked two, but only see "1 of 1" being upgraded).

 My suggestion that is patched is that we check to make sure at least one
 of the checked plugins are out of date. (If none, we break and display the
 message.) Then we pass ALL (including up-to-date) plugins to the upgrader,
 and let the upgrader provide feedback.

 There's a big thing outstanding here, and that is how this ties into
 #11232, which dd32 and I need to revisit. Pretty feedback in the upgrader
 is very important. That said, the patch here does not need to wait for us
 to finish our work there and is ready for testing and commit.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11542#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list