[wp-trac] [WordPress Trac] #11799: WPDB code improvements

WordPress Trac wp-trac at lists.automattic.com
Fri Jan 8 17:54:56 UTC 2010

#11799: WPDB code improvements
 Reporter:  hakre        |       Owner:  ryan     
     Type:  enhancement  |      Status:  new      
 Priority:  normal       |   Milestone:  3.0      
Component:  Database     |     Version:  3.0      
 Severity:  normal       |    Keywords:  has-patch

Comment(by Denis-de-Bernardy):

 isn't this missing a delimiter?

 if ( preg_match( '(^\s*([a-z]{2,})\s+)i', $query, $matches ) )

 also, I don't think it'll properly deal with:

 # some comments for debugging using SAVEQUERIES

 but nor does the current version of the class, so that's probably another

 also while we're at it, for reference, the code in wpmu does not deal with
 a tabbed update statements properly. (but yours does, since it follows the
 UPDATE with a \s instead of a space in the regexp.)

Ticket URL: <http://core.trac.wordpress.org/ticket/11799#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list