[wp-trac] [WordPress Trac] #6836: Prepare queries using INSERT/UPDATE should use wpdb::insert() or wpdb::update()

WordPress Trac wp-trac at lists.automattic.com
Fri Jan 8 05:35:15 UTC 2010


#6836: Prepare queries using INSERT/UPDATE should use wpdb::insert() or
wpdb::update()
----------------------------+-----------------------------------------------
 Reporter:  DD32            |        Owner:  ryan  
     Type:  defect (bug)    |       Status:  closed
 Priority:  normal          |    Milestone:  3.0   
Component:  Administration  |      Version:  2.6   
 Severity:  normal          |   Resolution:  fixed 
 Keywords:  has-patch       |  
----------------------------+-----------------------------------------------

Comment(by dd32):

 > Does it mean this ticket is partially fixed and some queries in upgrade
 related functions were not changed? If so, which were they?

 It means any changes to the upgrade scripts in the supplied patch were not
 commited, And will not be commited.

 The only reason is that testing DB changes made to the upgrade scripts is
 a serious undertaking, Its hard to test every case of every SQL branch,
 the current implementation is working and uses proper escaping, so its
 best left running as-is.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/6836#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list