[wp-trac] [WordPress Trac] #11598: code improvements in wp_:dashboard_plugins_output()

WordPress Trac wp-trac at lists.automattic.com
Tue Jan 5 21:01:32 UTC 2010


#11598: code improvements in wp_:dashboard_plugins_output()
--------------------------+-------------------------------------------------
 Reporter:  hakre         |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  normal        |   Milestone:  3.0      
Component:  General       |     Version:  2.9      
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------
Changes (by dd32):

  * keywords:  has-patch tested => has-patch


Comment:

 Does that {{{ do {} while(false); }}} loop work? That will only ever run
 once from looking at the code.

 Continue will just skip the rest of the loop and go straight to the
 conditional.

 Best to leave it as a {{{ while(true) { break;} }}}, Theres no need for
 the do syntax which is out of line with the rest of !WordPress

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11598#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list