[wp-trac] [WordPress Trac] #10555: number_format_i18n function doesn't check if the number is float or not before doing the formating

WordPress Trac wp-trac at lists.automattic.com
Tue Feb 23 16:06:11 UTC 2010


#10555: number_format_i18n function doesn't check if the number is float or not
before doing the formating
--------------------------+-------------------------------------------------
 Reporter:  chombium      |       Owner:  nbachiyski                   
     Type:  defect (bug)  |      Status:  new                          
 Priority:  normal        |   Milestone:  3.0                          
Component:  i18n          |     Version:  2.9                          
 Severity:  normal        |    Keywords:  has-patch needs-testing early
--------------------------+-------------------------------------------------

Comment(by scribu):

 Replying to [comment:10 nbachiyski]:
 > Replying to [comment:9 scribu]:
 > > Since we're on the topic, wouldn't it be nice to rename the function
 to `number_i18n`, to be consistent with `date_i18n` ?
 >
 > It is consistent. The PHP functions we are replicating are
 {{{number_format()}}} and {{{date()}}}.

 Then again, PHP isn't know for it's consistent function names...

 Either way, I like typing less. :-)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10555#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list