[wp-trac] [WordPress Trac] #12122: Unchecked Indexes in admin-ajax.php

WordPress Trac wp-trac at lists.automattic.com
Mon Feb 15 21:31:51 UTC 2010


#12122: Unchecked Indexes in admin-ajax.php
------------------------------+---------------------------------------------
 Reporter:  miqrogroove       |       Owner:  westi                  
     Type:  defect (bug)      |      Status:  new                    
 Priority:  normal            |   Milestone:  3.0                    
Component:  Warnings/Notices  |     Version:  2.9                    
 Severity:  minor             |    Keywords:  has-patch tested commit
------------------------------+---------------------------------------------

Comment(by nacin):

 With this we can probably remove an isset() check or two later in the
 file.

 Also, it looks like we check for !empty() for wp_ajax_nopriv_ but only
 isset() for wp_ajax_. Standardizing this on !empty() up top would be good.
 I don't see a reason for firing the literal hook "wp_ajax_" if admin-
 ajax.php?action is called.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12122#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list