[wp-trac] [WordPress Trac] #12122: Unchecked Indexes in admin-ajax.php

WordPress Trac wp-trac at lists.automattic.com
Mon Feb 15 14:10:59 UTC 2010


#12122: Unchecked Indexes in admin-ajax.php
------------------------------+---------------------------------------------
 Reporter:  miqrogroove       |       Owner:  westi                  
     Type:  defect (bug)      |      Status:  new                    
 Priority:  normal            |   Milestone:  3.0                    
Component:  Warnings/Notices  |     Version:  2.9                    
 Severity:  minor             |    Keywords:  has-patch tested commit
------------------------------+---------------------------------------------
Changes (by sivel):

  * keywords:  has-patch => has-patch tested commit


Comment:

 If we sent any status at all the preferred status would be 400.  However
 to properly send a 400 we would need to move the check after the call to
 wp-load.php so that we could use status_header() or we end up duplicating
 code.

 Honestly I still prefer to just die with a -1 since that is what we
 already do when the action is not hooked.  Otherwise we start sending
 inconsistent results back.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12122#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list