[wp-trac] [WordPress Trac] #15682: Entering invalid DB information causes WP installer to silently die()

[WordPress Trac]

#15682: Entering invalid DB information causes WP installer to silently die()
-----------------------------+----------------------------------------------
 Reporter:  itsananderson    |       Owner:     
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.1
Component:  Upgrade/Install  |     Version:  3.1
 Severity:  major            |    Keywords:     
-----------------------------+----------------------------------------------

Comment(by nacin):

 Replying to [comment:3 zippykid]:
 > I think a more elegant solution may be to set show_errors(true) in the
 constructor of wpdb, if WP_INSTALLING === true.

 That sounds fine.

 We don't need to check for === true. In fact, we can't, because sometimes
 it won't be defined, and that'll trigger a notice.

 We instead want to just check `defined( 'WP_INSTALLING' )`. Line 499,
 where it says `if ( WP_DEBUG )` can change to `if ( WP_DEBUG || defined(
 'WP_INSTALLING' ) )`.

 Actually, we want that to be `defined( 'WP_SETUP_CONFIG' )` instead. We'll
 call show_errors() ourselves during the install process.

 I doubt this has been caught previously since we test typically with
 WP_DEBUG on.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15682#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software