[wp-trac] [WordPress Trac] #15615: Left admin menu slides open, hides closed

WordPress Trac wp-trac at lists.automattic.com
Tue Dec 7 23:24:04 UTC 2010


#15615: Left admin menu slides open, hides closed
-----------------------------+----------------------------------------------
 Reporter:  johnjamesjacoby  |       Owner:           
     Type:  defect (bug)     |      Status:  new      
 Priority:  normal           |   Milestone:  3.1      
Component:  Administration   |     Version:  3.1      
 Severity:  minor            |    Keywords:  has-patch
-----------------------------+----------------------------------------------

Comment(by filosofo):

 The real question is why this was working in 3.0.x.  The reason it
 shouldn't have worked is that the jQuery chained methods get executed
 before the callback called when the animation is complete.  That means
 that the "wp-menu-open" class should be toggled  in the callback, once the
 sliding animation is complete.

 The best answer I have is that with every release, jQuery gets twice as
 fast.  3.0.x uses jQuery 1.4.2, and 3.1, 1.4.4.  Folks, that's 4x as fast.
 I tried this with the trunk version of jQuery, and it was so fast that the
 sliding submenu actually went back in time.

 So clearly we need the class toggle after the animation is complete, as in
 `toggle-class-in-callback.15615.diff`.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15615#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list