[wp-trac] [WordPress Trac] #13173: get_date_from_gmt does not properly convert non-DST dates when DST is in effect and vice versa.

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 29 05:17:17 UTC 2010


#13173: get_date_from_gmt does not properly convert non-DST dates when DST is in
effect and vice versa.
--------------------------+-------------------------------------------------
 Reporter:  cfinke        |       Owner:     
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.1
Component:  Date/Time     |     Version:  3.0
 Severity:  normal        |    Keywords:     
--------------------------+-------------------------------------------------

Comment(by solarissmoke):

 Replying to [comment:2 nacin]:
 > Isn't this a duplicate of #9285?

 Possibly, though they are related to different functions. The issue here
 is that get_date_from_gmt() assumes that the current timezone offset
 equals the timezone offset for whatever time-string it is given. The issue
 with #9825 is that get_gmt_from_date() is doing the same thing in reverse.

 I think having a get_gmt_offset() function would help fix both of these,
 rather than having separate timezone-handling code in both of
 get_date_from_gmt() and get_gmt_from_date(). The main problem is that
 currently any use of get_option('gmt_offset') assumes that we're dealing
 with the present.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13173#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list