[wp-trac] [WordPress Trac] #12275: get_themes() returns formatted data

WordPress Trac wp-trac at lists.automattic.com
Sun Apr 25 22:09:56 UTC 2010


#12275: get_themes() returns formatted data
--------------------------+-------------------------------------------------
 Reporter:  GeorgWP       |       Owner:              
     Type:  defect (bug)  |      Status:  new         
 Priority:  normal        |   Milestone:  3.0         
Component:  General       |     Version:  2.9.2       
 Severity:  normal        |    Keywords:  dev-feedback
--------------------------+-------------------------------------------------
Changes (by blepoxp):

  * keywords:  get_themes() => dev-feedback


Comment:

 Replying to [comment:1 nacin]:
 > Not sure if changing it back is worth it, but this sounds like it is due
 to abstraction to get_file_data(). Setting to 3.0 for review.

 Ping me if you'd like any type of patch for this. I checked in theme.php
 and its set on line 230. I'm not sure if its worth changing back. I did a
 quick look to see what else uses that information. Most if it is -
 surprise - on the theme admin pages. All instances I saw are being printed
 with printf functions. In those cases, its nice that the author is
 delivered with the AuthorURI link already embeded so that we don't have to
 build the link in every instance.

 I don't think it would be worth changing it back because we'd have to
 update the code everywhere that its currently used (to build the link
 using AuthorURI).

 If you feel like its important enough, I could add another key to the
 $theme_data array, returning [ 'AuthorName' ] or something.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12275#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list