[wp-trac] [WordPress Trac] #8841: Threaded comments display out of order if conditions are met.

WordPress Trac wp-trac at lists.automattic.com
Fri Oct 16 22:57:37 UTC 2009


#8841: Threaded comments display out of order if conditions are met.
--------------------------+-------------------------------------------------
 Reporter:  clifgriffin   |       Owner:             
     Type:  defect (bug)  |      Status:  new        
 Priority:  normal        |   Milestone:  2.9        
Component:  Comments      |     Version:  2.7        
 Severity:  normal        |    Keywords:  needs-patch
--------------------------+-------------------------------------------------

Comment(by hailin):

 sorry I wasn't aware of this discussion earlier.

 1. "change the comment walker to ignore the depth limit when listing
 comments"
    we can just call the walker with max_depth = big number (such as 9999),
    but don't include "reply" link on comments beyond the max_depth.


 2. "the walker should enforce the max_depth, and treat all comments beyond
 a certain real_depth as being of max_depth -- with the two variables being
 counted for separately"

   This may work well, I think. Say if users first set levels to 10, then
 changed it to 4. So for all comments between level 5 and 10, we just put
 them on the same level as 4. Not sure if there is any side effect.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8841#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list