[wp-trac] [WordPress Trac] #10997: XHTML in comments_popup_link title attribute

WordPress Trac wp-trac at lists.automattic.com
Mon Nov 2 20:19:57 UTC 2009


#10997: XHTML in comments_popup_link title attribute
--------------------------+-------------------------------------------------
 Reporter:  ewestp        |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  normal        |   Milestone:  2.9      
Component:  Comments      |     Version:  2.8.4    
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by ewestp):

 Here is a simple test to highlight the problem.

 1) Using the default theme, make a new post with the title
 {{{
 The &lt;em&gt; tag adds <em>emphasis</em>
 }}}
 2) On the front page, mouse over the permalink made from the post title.
 The title attribute looks nice--no tags around the word 'emphasis'.

 3) Mouse over the link to the post's comments. The title attribute looks
 messy because there are tags around the word 'emphasis' which obviously
 don't belong there.

 Why aren't the links' title attributes consistent? Because the permalink
 uses the_title_attribute() to construct a clean title attribute (a
 function that seems to have been made expressly for that purpose), and
 comments_popup_link() does not.

 If you use the search-everything plugin with highlighting enabled, search
 for any of the words in the post's title and witness the horror that is
 the title attribute of the comments link.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10997#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list