[wp-trac] Re: [WordPress Trac] #8095: Display core upgrade message earlier

WordPress Trac wp-trac at lists.automattic.com
Mon May 11 13:08:11 GMT 2009


#8095: Display core upgrade message earlier
-----------------------------+----------------------------------------------
 Reporter:  MichaelH         |       Owner:             
     Type:  defect (bug)     |      Status:  new        
 Priority:  normal           |   Milestone:  2.8        
Component:  Upgrade/Install  |     Version:  2.7        
 Severity:  normal           |    Keywords:  needs-patch
-----------------------------+----------------------------------------------
Changes (by Denis-de-Bernardy):

  * milestone:  2.9 => 2.8


Comment:

 I *think* the mega flush should occur earlier in the process. Personally,
 I've a plugin that uses the core upgrade tools to upgrade a patched
 version of WP. It changes a few captions along the way.

 As this was not pluginable at all until recently, I sorted this out by
 using output buffers in the feedback messages. As in, I'd flush all
 buffers, and then restart an ob_start(edit_captions).

 That way, messages would still get displayed, but the screen would still
 be pluginable.

 Side note: WP doesn't add any output buffers on that screen all by itself.
 Might your issue be server-related? (as in, it's automatically started by
 the host.) If so, placing the flush all at the beginning of the page (e.g.
 add_action(load-upgrade.php, wp_ob_end_flush_all, 0) or something like
 that) may do the trick as well.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8095#comment:8>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list