[wp-trac] Re: [WordPress Trac] #9635: Comments Query Needs Filters

[WordPress Trac]

#9635: Comments Query Needs Filters
--------------------------+-------------------------------------------------
 Reporter:  filosofo      |       Owner:                                                     
     Type:  defect (bug)  |      Status:  new                                                
 Priority:  normal        |   Milestone:  2.8                                                
Component:  Comments      |     Version:  2.8                                                
 Severity:  normal        |    Keywords:  comments-query has-patch tested commit dev-feedback
--------------------------+-------------------------------------------------
Changes (by Denis-de-Bernardy):

  * keywords:  comments-query has-patch => comments-query has-patch tested
               commit dev-feedback


Comment:

 current patch is harmless.

 adding dev-feedback keyword on one point, which is the group by.

 in the posts query, group by is assumed to not contain any GROUP BY
 clause, i.e. if non-empty groupby then groupby = GROUP BY groupby.

 whereas in the comments query, it's assumed to contain the GROUP BY
 clause. it's not much of a big deal, but at the risk of breaking a plugin
 or two we might want those two to be kept consistent.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9635#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software