[wp-trac] Re: [WordPress Trac] #4011: add global proxy support in options

[WordPress Trac]

#4011: add global proxy support in options
-----------------------------+----------------------------------------------
 Reporter:  tmountjr         |       Owner:  jacobsantos                         
     Type:  feature request  |      Status:  new                                 
 Priority:  normal           |   Milestone:  2.8                                 
Component:  HTTP             |     Version:  2.2                                 
 Severity:  normal           |    Keywords:  proxy has-patch commit needs-testing
-----------------------------+----------------------------------------------

Comment(by bforchhammer):

 Wow, I love the work you're doing here... We are running one of those
 corporate wordpress installs behind a firewall and this is helping us very
 much already. Thanks!

 I had a look at http.php HEAD & patch 4011.5.diff and here's a few things
 I stumbled on:

 line 121 and 169: if `has_filter()` condition then `do_action()` call.
 [[BR]]> Shouldn't that be either `has_action()` and `do_action()` or
 `has_filter()` and `apply_filter()` ?

 lines 549 and 1498, for example `is_array( WP_ACCESSABLE_HOSTS )`.
 [[BR]]> I am not sure that php allows to set constants to "arrays". Afaik
 only scalar values (integer, float, string, boolean) are accepted.
 Solution might be to serialise & unserialize the array or use a string
 instead (e.g. pipe `|` separated?).

 lines 536 and 1513: `get_bloginfo('site_url')`
 [[BR]]> `'site_url'` is not a valid parameter; according to the codex doc
 on [http://codex.wordpress.org/Template_Tags/get_bloginfo get_bloginfo] it
 should be `'url'` since 2.7 (or `'siteurl'` should work but is deprecated
 apparently).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/4011#comment:28>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software