[wp-trac] Re: [WordPress Trac] #10300: Optimization in wp_get_sidebars_widgets() corrupts the widgets

[WordPress Trac]

#10300: Optimization in wp_get_sidebars_widgets() corrupts the widgets
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:  azaozz
     Type:  defect (bug)       |      Status:  new   
 Priority:  normal             |   Milestone:  2.8.1 
Component:  Widgets            |     Version:  2.8   
 Severity:  normal             |    Keywords:        
-------------------------------+--------------------------------------------

Comment(by Denis-de-Bernardy):

 odd that I didn't receive any emails on this one. trac seems broken.

 haven't tested, but the logic is incorrect.

 10300.2.patch prevents the sidebars_widgets filter from getting applied
 differently from a call to the next. on occasion, you want to do something
 like this:

 {{{
 if ( !is_active_sidebar('my_sidebar') ) {
   add_filter('sidebars_widgets', 'my_sidebar_autofill');
 }
 }}}

 your patch removes that possibility. (mine doesn't)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10300#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software