[wp-trac] Re: [WordPress Trac] #9913: Plain text emails sent with encoded quotes

WordPress Trac wp-trac at lists.automattic.com
Mon Jun 15 10:41:27 GMT 2009


#9913: Plain text emails sent with encoded quotes
--------------------------+-------------------------------------------------
 Reporter:  Speedboxer    |       Owner:                        
     Type:  defect (bug)  |      Status:  new                   
 Priority:  normal        |   Milestone:  2.9                   
Component:  Mail          |     Version:  2.8                   
 Severity:  normal        |    Keywords:  has-patch dev-feedback
--------------------------+-------------------------------------------------
Changes (by hakre):

  * keywords:  has-patch 2nd-opinion => has-patch dev-feedback


Comment:

 Well best would be that it is clear that wp_mail() would expect data that
 is plain/text encoded in the default charset. the default charset should
 be named as well. stick with utf-8 here?

 the all needed decisions can be taken care of. mostly I assume the problem
 is not located inside wp_mail even thought the provided patch is a
 workaround on that (wrong) place.

 I could not take a very decent look into it right now, but it looks that
 contet_type comes out of nowhere and then a (reasonable) decision is bound
 to it.

 what about the idea to have an esc_mail() compagnon to esc_html() that is
 used in combination with wp_mail at the places where wp_mail() currently
 is used with esc_html()? This would leave us enough space for changes in
 the future and the place to fix walks in the right (imho) direction: not
 inside wp_mail(). wp_mail needs a clear statement in the docblocks of how
 string parameters are to be expected: charset/encoding.

 what about some feedback on that basic point from core devs? as far as I
 read the docblocks, it's only string: can be plain text, can be html can
 be utf8 but can be latin1 as well. my suggestion is to have it plain here
 (this is an email and those are normally plain, no need for fancy html
 upfront) and utf-8 encoded because utf-8 is used more and more and I would
 like to have it as "default charset" within all routines.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9913#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list