[wp-trac] Re: [WordPress Trac] #10140: Files being deleted during upgrade

[WordPress Trac]

#10140: Files being deleted during upgrade
------------------------------+---------------------------------------------
 Reporter:  takayukister      |        Owner:  dd32  
     Type:  defect (bug)      |       Status:  closed
 Priority:  highest omg bbq   |    Milestone:  2.8.1 
Component:  Upgrade/Install   |      Version:  2.8   
 Severity:  blocker           |   Resolution:  fixed 
 Keywords:  has-patch commit  |  
------------------------------+---------------------------------------------

Comment(by dd32):

 > It seems the only way for this to happen is when update_core.php is from
 2.8 but the WP_Filesystem classes are from 2.7. That could happen when an
 upgrade fails in the middle of copying files.

 Almost.

 The process for a core upgrade is different from what you're thinking. The
 core upgrade extracts the files to a temporary folder, Then copies the new
 upgrade-core.php file into place (overwriting the previous version's
 file), Then includes it. So an upgrade will always have the new versions
 upgrade-core.php file, and the old files for everything else.

 So this problem only ever occurs if the upgrade crashes half way through,
 ie. It extrats all files fine, But the process of copying new files into
 the new location fails.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10140#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software