[wp-trac] Re: [WordPress Trac] #8210: SSH2 Filesystem transport; Multiple issues

[WordPress Trac]

#8210: SSH2 Filesystem transport; Multiple issues
-------------------------------------+--------------------------------------
 Reporter:  DD32                     |        Owner:     
     Type:  defect (bug)             |       Status:  new
 Priority:  normal                   |    Milestone:  2.8
Component:  Upgrade                  |      Version:  2.7
 Severity:  normal                   |   Resolution:     
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------
Changes (by t.baboon):

  * keywords:  needs-patch => has-patch needs-testing

Comment:

 My attached patch seems to fix problems #1 and #2 above (dashes in the
 beginning of filenames and special characters in filenames causing the
 potential execution of shell commands), while not addressing problem #3
 (moving to "ssh2.sftp://"). It uses escapeshellarg() on all paths and adds
 the string "./" in front of all relative paths or filenames (ones that
 don't start with a slash), which should fix #1 and #2.

 I've not tested it extensively, so some testing assistance would be
 appreciated.

 -- t.baboon

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8210#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software