[wp-trac] [WordPress Trac] #11582: Code editor bug in Safari

WordPress Trac wp-trac at lists.automattic.com
Thu Dec 24 07:22:00 UTC 2009


#11582: Code editor bug in Safari
--------------------------+-------------------------------------------------
 Reporter:  WraithKenny   |       Owner:                        
     Type:  defect (bug)  |      Status:  new                   
 Priority:  normal        |   Milestone:  2.9.1                 
Component:  Editor        |     Version:  2.9                   
 Severity:  normal        |    Keywords:  has-patch needs-review
--------------------------+-------------------------------------------------
Changes (by nacin):

  * keywords:  => has-patch needs-review
  * milestone:  3.0 => 2.9.1


Comment:

 Got it. It's an unnecessary {{{<br class="clear" />}}}. To explain, this
 would clear the .fileedit-sub div, which doesn't need to be cleared.
 (Elements in the .fileedit-sub div do need to be cleared, and they are.)
 This troublesome piece of markup only exists in the theme editor; the
 plugin editor is spared.

 Here's the interesting part -- I actually can't find where this piece of
 code was slipped in. It exists in 2.9 and trunk, but not 2.8. Couldn't
 find it in blame. I then looked through all changesets on this file since
 2.8 and still couldn't find it. So if anyone can find when it was added,
 I'd love to see it.

 This is definitely a 2.8 regression. Moving to 2.9.1. Please test -- with
 the patch, I confirm as fixed on both Chrome and Safari.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11582#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list