[wp-trac] [WordPress Trac] #11442: Untrashed comments could be deleted by wp_scheduled_delete()

[WordPress Trac]

#11442: Untrashed comments could be deleted by wp_scheduled_delete()
--------------------------+-------------------------------------------------
 Reporter:  nacin         |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  high          |   Milestone:  2.9      
Component:  Trash         |     Version:  2.9      
 Severity:  blocker       |    Keywords:  has-patch
--------------------------+-------------------------------------------------
Changes (by nacin):

  * severity:  blocker => blocker


Comment:

 Replying to [comment:18 caesarsgrunt]:
 > Replying to [comment:16 nacin]:
 > > I'm trying to run it through my head for how trashed -> spammed (and
 vice versa) would work
 > Shouldn't ever happen...

 That's the point of the ticket. If a comment is already trashed, a link in
 a notif email will still take you to the comment SYS form and allow a
 change in status without untrashing. I'm going to work on a patch later
 today for that but I anticipated that being 3.0, as it isn't a regression
 (as long as the blocker is fixed).

 > > Patch 5: I actually liked the simple wp_(action)_comment() functions
 as an API. They've also been around long enough in beta that removing them
 might be a compat issue. Combining them I suppose makes sense though.
 > I don't think removing them could be a compat issue. Anyone developing a
 plugin against a beta release should be prepared to have to make changes.
 And these are pretty minor changes from an API point of view.

 But they're still simple, easy to use, and named well. I don't care so
 much either way.

 > > Do we add back all sorts of pre- and post- actions?
 > I don't understand. What do you mean?

 Ex.: The trash_comment hook ran before a comment was trashed, and a
 trashed_comment hook ran once trashed (if successful).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11442#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software