[wp-trac] [WordPress Trac] #11442: Untrashed comments could be deleted by wp_scheduled_delete()

WordPress Trac wp-trac at lists.automattic.com
Tue Dec 15 20:29:17 UTC 2009


#11442: Untrashed comments could be deleted by wp_scheduled_delete()
--------------------------+-------------------------------------------------
 Reporter:  nacin         |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  high          |   Milestone:  2.9      
Component:  Trash         |     Version:  2.9      
 Severity:  blocker       |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by caesarsgrunt):

 Replying to [comment:16 nacin]:
 > I'm trying to run it through my head for how trashed -> spammed (and
 vice versa) would work
 Shouldn't ever happen...

 > Patch 5: I actually liked the simple wp_(action)_comment() functions as
 an API. They've also been around long enough in beta that removing them
 might be a compat issue. Combining them I suppose makes sense though.
 I don't think removing them could be a compat issue. Anyone developing a
 plugin against a beta release should be prepared to have to make changes.
 And these are pretty minor changes from an API point of view.

 > Do we add back all sorts of pre- and post- actions?
 I don't understand. What do you mean?

 > Spam didn't previously have an expiration time
 It still doesn't - the time it was spammed gets stored in the DB like
 trash, because that's just simpler, but it is never automatically deleted.
 > they just got wiped by wp_scheduled_delete() (at least how I understood
 it).
 No, spam is never automatically deleted at any point.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11442#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list