[wp-trac] [WordPress Trac] #11315: Versioning is being forced for JavaScript and CSS assets with no override

WordPress Trac wp-trac at lists.automattic.com
Sat Dec 5 01:13:57 UTC 2009


#11315: Versioning is being forced for JavaScript and CSS assets with no override
-------------------------+--------------------------------------------------
 Reporter:  amattie      |       Owner:  azaozz
     Type:  enhancement  |      Status:  new   
 Priority:  normal       |   Milestone:  3.0   
Component:  JavaScript   |     Version:  2.9   
 Severity:  normal       |    Keywords:        
-------------------------+--------------------------------------------------

Comment(by scribu):

 Replying to [comment:11 amattie]:
 > Regarding the purpose of this:
 > {{{
 >       235                     if ( $this->ver === false )
 > 236   236                             $this->ver = false;
 > }}}
 >
 > You're correct in that that's kinda useless, but perhaps 235-236 should
 be removed altogether then. Without removing it (as it is in
 11315_override.diff or 11315_remove.diff), $this->ver is set to false if
 an empty string is passed in since '' evals to false.

 But they ''are'' removed altogether in both patches.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11315#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list