[wp-trac] [WordPress Trac] #11315: Versioning is being forced for JavaScript and CSS assets with no override

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 4 11:06:06 UTC 2009


#11315: Versioning is being forced for JavaScript and CSS assets with no override
-------------------------+--------------------------------------------------
 Reporter:  amattie      |       Owner:  azaozz     
     Type:  enhancement  |      Status:  new        
 Priority:  normal       |   Milestone:  3.0        
Component:  JavaScript   |     Version:  2.9        
 Severity:  normal       |    Keywords:  needs-patch
-------------------------+--------------------------------------------------

Comment(by scribu):

 Replying to [comment:4 dd32]:
 > Damn formatter..
 >
 > {{{
 >  ('' == false && 0 == false & null == false && array() == false && false
 == false) == true
 > }}}

 No, I mean what's the point of checking for false, and then assigning
 false to the same variable?

 I've added two patches:

 [http://core.trac.wordpress.org/attachment/ticket/11315/11315_remove.diff
 11315_remove.diff] removes the default version altogether, since it isn't
 that useful, IMO

 [http://core.trac.wordpress.org/attachment/ticket/11315/11315_override.diff
 11315_override.diff] corrects the patch from amattie and includes the
 default version only when not explicitly set by the user.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11315#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list