[wp-trac] [WordPress Trac] #10948: wp_list_comments() always assumes walker will echo.

WordPress Trac wp-trac at lists.automattic.com
Tue Dec 1 17:58:12 UTC 2009


#10948: wp_list_comments() always assumes walker will echo.
--------------------------+-------------------------------------------------
 Reporter:  MikeLittle    |       Owner:                 
     Type:  defect (bug)  |      Status:  new            
 Priority:  normal        |   Milestone:  3.0            
Component:  Comments      |     Version:  2.8.6          
 Severity:  normal        |    Keywords:  has-patch early
--------------------------+-------------------------------------------------
Changes (by ryan):

  * keywords:  has-patch => has-patch early
  * milestone:  2.9 => 3.0


Comment:

 We might want to do get_edit_comment_link() instead of an echo flag to
 match what we do elsewhere.  Otherwise, looks good. Unfortunately, we
 overlooked this ticket in time to get it into 2.9. Let's mark as early 3.0
 and get this in as soon was we branch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10948#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list