[wp-trac] Re: [WordPress Trac] #4027: Upgrade function don't do ANY error checking whatsoever

[WordPress Trac]

#4027: Upgrade function don't do ANY error checking whatsoever
----------------------------+-----------------------------------------------
 Reporter:  skjaeve         |       Owner:                   
     Type:  defect (bug)    |      Status:  new              
 Priority:  high            |   Milestone:  2.9              
Component:  Administration  |     Version:  2.1.2            
 Severity:  critical        |    Keywords:  early needs-patch
----------------------------+-----------------------------------------------

Comment(by Denis-de-Bernardy):

 > Any discussion on how this could be implemented? Should failed queries
 cause the script to bail?

 if so, they should only bail once all of the dbDelta queries have run, but
 not at any point after -- and this would only really treat a problem in an
 alter table statement.

 keep in mind that you cannot rollback. if dbDelta worked, the rest should
 work as well... whereas if you're moving the stuff from post_categories
 into newly created terms tables, and it stops in the middle and refuses to
 go any further when it runs into an error, your install needs some severe
 db maintenance before you can recover anything.

 imo, if the user knows SQL well enough to configure the permissions to
 something other than "grant all" or nearly so, surely he can fix his
 install if something goes wrong. the only thing he does need to see are
 the db error messages, which are no longer shown since around 2.5 or 2.6.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/4027#comment:11>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software