[wp-trac] Re: [WordPress Trac] #6593: Tags with custom slugs get recreated on post edit screen

WordPress Trac wp-trac at lists.automattic.com
Wed Nov 12 01:24:02 GMT 2008


#6593: Tags with custom slugs get recreated on post edit screen
--------------------------------------------+-------------------------------
 Reporter:  jhodgdon                        |        Owner:  ryan    
     Type:  defect                          |       Status:  reopened
 Priority:  normal                          |    Milestone:  2.7     
Component:  Administration                  |      Version:  2.5     
 Severity:  normal                          |   Resolution:          
 Keywords:  tags, has-patch, needs-testing  |  
--------------------------------------------+-------------------------------
Changes (by DD32):

  * keywords:  tags, has-patch => tags, has-patch, needs-testing

Comment:

 > attachment 6593.diff added.
  * Fixes the issue of having tags with conflicting slugs, Eg, 'C++' =>
 slug 'c', 'C' => slug 'c', After the patch, 'C' would get 'c-2'
  * Fixed the custom slug issue, Eg, Tagname: 'Jokes', slug: 'great-jokes',
 Adding a tag 'Great Jokes' will no longer recieve the slug 'great-
 jokes'(Which subsequently means the new tag vanishes) and will instead,
 get 'great-jokes-2'

  * Adding a Tag of 'C++' => slug 'c', and then adding a Category of 'C++'
 results in a category and tag with the same slug 'c', According to the
 Taxonomy documentation, The slug needs to be unique accross all
 taxonomies, Therefor, This patch will also cause the above to take the
 form of (tag)'C++' => slug 'c', (cat)'C++' => slug 'c-2', If this isnt the
 intended behaviour and the docs are wrong, {{{wp_unique_term_slug()}}}
 needs to be updated to take into account the taxonomy

 Patch obviously needs some testing.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6593#comment:34>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list