[wp-trac] Re: [WordPress Trac] #6293: phpass should use uniqid(), not getmypid()

WordPress Trac wp-trac at lists.automattic.com
Wed Mar 19 19:41:30 GMT 2008


#6293: phpass should use uniqid(), not getmypid()
------------------------+---------------------------------------------------
 Reporter:  tellyworth  |        Owner:  anonymous
     Type:  defect      |       Status:  new      
 Priority:  normal      |    Milestone:  2.5      
Component:  General     |      Version:  2.5      
 Severity:  blocker     |   Resolution:           
 Keywords:  has-patch   |  
------------------------+---------------------------------------------------
Comment (by ryan):

 Solar Designer sent me a detailed reply, which I'll try to summarize here.
 In general, getmypid() is sufficient for this fallback code path even if
 disabled, but if we want to address the warning we can use this:

 {{{
 $this->random_state = microtime() . (function_exists("getmypid") ?
 getmypid() : "") . uniqid(rand(), TRUE);
 }}}

 This won't go into upstream phpass for awhile due to it's PHP3 dependency,
 but we can add it if we like.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6293#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list