[wp-trac] [WordPress Trac] #5937: Thickbox implementation conflict

WordPress Trac wp-trac at lists.automattic.com
Wed Feb 20 18:25:51 GMT 2008


#5937: Thickbox implementation conflict
----------------------+-----------------------------------------------------
 Reporter:  alexrabe  |       Owner:  anonymous       
     Type:  defect    |      Status:  new             
 Priority:  normal    |   Milestone:  2.5             
Component:  General   |     Version:  2.5             
 Severity:  normal    |    Keywords:  Thickbox, jQuery
----------------------+-----------------------------------------------------
 The new image uploader in #5609 uses a modified Thickbox version :

   "I made some wp-specific changes to the Thickbox js: $() changed to
 jQuery(); addLoadEvent() instead of read() (thanks mdawaffe); and the
 close link changed to a [x] png as per the design spec."

 Plugins (like NextGEN Gallery) also uses often the Thickbox effect to show
 larger popup images. Due to the fact that I uses the script loader with
 {{{ wp_enqueue_script('thickbox'... }}} the wp-specific version gets
 loaded in the frontend and failed due to the fact that addLoadEvent()
 didn't exist.[[BR]]

 Solution could be :

 a) Rename the wp-specific version in the script-loader to "WP-Thickbox" or
 whatever[[BR]]
 b) Move addLoadEvent() outside of the thickbox script[[BR]]
 c) All plugins must deregister "Thickbox" and add the offical one, which
 could then affected the Image uploader in the backend...

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5937>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list