[wp-trac] Re: [WordPress Trac] #8580: Automatic plugin ftp value stored improperly if FTP failed. causing function to break for good

[WordPress Trac]

#8580: Automatic plugin ftp value stored improperly if FTP failed. causing
function to break for good
---------------------+------------------------------------------------------
 Reporter:  dwenaus  |        Owner:       
     Type:  defect   |       Status:  new  
 Priority:  normal   |    Milestone:  2.7.1
Component:  Upgrade  |      Version:  2.7  
 Severity:  normal   |   Resolution:       
 Keywords:           |  
---------------------+------------------------------------------------------
Changes (by Otto42):

  * version:  => 2.7

Comment:

 Port is definitely sticking, which it should not do. Line 670:

 {{
 if ( strpos($credentials['hostname'], ':') )
         list( $credentials['hostname'], $credentials['port'] ) =
 explode(':', $credentials['hostname'], 2);
 }}

 The credentials are loaded from the options table, then overridden like
 this. If the port was specified before and is not specified now (no colon
 in the hostname), then it doesn't get changed from its previous value.

 Port should default to 21 if no port is specified. A simple else
 $credentials['port'] = 21 after this bit of code would fix it.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8580#comment:5>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software