[wp-trac] Re: [WordPress Trac] #6836: Prepare queries using INSERT/UPDATE should use wpdb::insert() or wpdb::update()

WordPress Trac wp-trac at lists.automattic.com
Fri Apr 25 08:33:13 GMT 2008


#6836: Prepare queries using INSERT/UPDATE should use wpdb::insert() or
wpdb::update()
----------------------------+-----------------------------------------------
 Reporter:  DD32            |        Owner:  anonymous
     Type:  defect          |       Status:  new      
 Priority:  normal          |    Milestone:  2.6      
Component:  Administration  |      Version:  2.6      
 Severity:  normal          |   Resolution:           
 Keywords:                  |  
----------------------------+-----------------------------------------------
Comment (by DD32):

 > attachment 6836.diff added.

 Note: There was a escaping issue with adding meta/updating meta, ' and "
 were being double escaped. Patch as such removes the double escpaping.

 Also renamed a few variables so as to use compact('meta_value') instead of
 array('meta_value' => $metavalue,..). Just makes it look a bit more clean
 and keeps fields named the same throughout.

 All Meta changes were tested working, The last chunk(Change to
 {{{_relocate_children()}}}) hasnt been tested, But i see no reason it
 should fail.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6836#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list