[wp-trac] Re: [WordPress Trac] #6444: Changeset 7561 (post rc3) leaves an open <p> at the end of the inserted gallery html

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 24 16:21:28 GMT 2008


#6444: Changeset 7561 (post rc3) leaves an open <p> at the end of the inserted
gallery html
-------------------------------------+--------------------------------------
 Reporter:  johnconners              |        Owner:  andy  
     Type:  defect                   |       Status:  closed
 Priority:  high                     |    Milestone:  2.5.1 
Component:  Template                 |      Version:  2.5   
 Severity:  critical                 |   Resolution:  fixed 
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------
Comment (by AaronCampbell):

 I'm thinking about it, but so far I don't see a real quality way of
 handling this.  As it sits now, the user is supposed to call do_shortcodes
 on their content ```if``` they want to allow recursive handling inside
 their tags, so they would need to call do_shortcodes($content) if they
 used pre-autop, and do_shortcodes($content, true); or
 do_shortcode_after_formatting($content); if they used the post-autop.

 If this is ultimately meant for other applications (such as comments), I'm
 thinking it might be useful to allow for different sets of shortcodes
 anyway (more advanced than we currently have).  I don't want one of my
 users adding [gallery id='123'] in order to add a gallery related to
 another post to this one.

 I'm just trying to throw this out there for discussion, so we can solve as
 many problems as soon as possible, rather than later.  It's better (in my
 opinion) to break backwards compatibility now (when there isn't a lot of
 history to worry about), than worry about it later when 100s of plugins
 already rely on it.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6444#comment:25>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list