[wp-trac] Re: [WordPress Trac] #5185: SQL Error on feeds for invalid posts

WordPress Trac wp-trac at lists.automattic.com
Thu Oct 25 02:39:43 GMT 2007

#5185: SQL Error on feeds for invalid posts
 Reporter:  robertaccettura                       |        Owner:  anonymous
     Type:  defect                                |       Status:  new      
 Priority:  normal                                |    Milestone:  2.4      
Component:  General                               |      Version:  2.3      
 Severity:  major                                 |   Resolution:           
 Keywords:  sql, error, feed, query.php, invalid  |  
Comment (by robertaccettura):

 I presume that's for the trunk.  I've only got 2.3 running atm...

 -              if ( $this->is_comment_feed && $this->is_singular ) {
 +                if ( $this->is_comment_feed && $this->is_singular &&
 $this->have_posts() ) {


 Not really fixing it.

 For example:

 Title on feed reads: Comments on: ...

 For example
 Title on feed reads: Blog Name » 2007 » October » 14

 I think throwing a 404 is 100% acceptable to be perfectly honest.  AFAIK
 most feed readers do know/understand the header.  Most are very http
 complaint (thanks to 301's and If-Modified-Since). Those that don't will

 a) do nothing (not so bad considering the situation).
 b) find the feed invalid (not so bad considering there is no feed).

Ticket URL: <http://trac.wordpress.org/ticket/5185#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list