[wp-trac] Re: [WordPress Trac] #1435: Pages should be searched

WordPress Trac wp-trac at lists.automattic.com
Wed Mar 28 14:47:02 GMT 2007


#1435: Pages should be searched
----------------------------------------------+-----------------------------
 Reporter:  markjaquith                       |        Owner:  anonymous
     Type:  enhancement                       |       Status:  new      
 Priority:  high                              |    Milestone:  2.3      
Component:  General                           |      Version:  1.5.1.1  
 Severity:  critical                          |   Resolution:           
 Keywords:  search pages static dev-feedback  |  
----------------------------------------------+-----------------------------
Comment (by Otto42):

 I don't see why having them in the loop is such a big deal. We put
 trackbacks and pingbacks in the comments loop. Most themes don't bother to
 separate them, although they could do it via CSS, since the information is
 available as part of the comment ($comment_type).

 Similarly, if search returns pages in the loop, then the theme can choose
 whether or not to separate them out based on $post->post_type.

 We should not lock themes into doing it only one way. Stick the results in
 the loop. Themes can determine for themselves whether or not to display
 it. If you like, make the search default to returning only posts unless
 there's a "searchpages=true" hidden parameter or something. Again, this
 leaves it up to the theme (or at least, the search form).

-- 
Ticket URL: <http://trac.wordpress.org/ticket/1435#comment:10>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list