[wp-trac] Re: [WordPress Trac] #3911: Javascript should not be localized by via PHP

WordPress Trac wp-trac at lists.automattic.com
Mon Mar 5 23:35:28 GMT 2007


#3911: Javascript should not be localized by via PHP
-----------------------------------+----------------------------------------
 Reporter:  mdawaffe               |        Owner:  mdawaffe
     Type:  defect                 |       Status:  assigned
 Priority:  high                   |    Milestone:  2.2     
Component:  Optimization           |      Version:  2.1.2   
 Severity:  normal                 |   Resolution:          
 Keywords:  has-patch 2nd-opinion  |  
-----------------------------------+----------------------------------------
Comment (by majelbstoat):

 +1 for this.  At the moment I have to resort to defining variables in
 admin_head() and wp_head() which is ugly to say the least.

 What object will the passed variables be attached to? (window, or a some
 other?) It seems to be magically attached to tempobj somehow...?

 And in your patch, I didn't quite see what

 {{{
  - if ( this.theList.childNodes.length % 2 )
  + if ( ( this.theList.childNodes.length + this.altOffset ) % 2 )
 }}}

 did, or whether it was part of the changes?

-- 
Ticket URL: <http://trac.wordpress.org/ticket/3911#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list