[wp-trac] [WordPress Trac] #4586: Send to Editor doesn't work when WordPress is loaded in a frame.

[WordPress Trac]

#4586: Send to Editor doesn't work when WordPress is loaded in a frame.
----------------------------+-----------------------------------------------
 Reporter:  semicharm       |       Owner:  anonymous          
     Type:  defect          |      Status:  new                
 Priority:  normal          |   Milestone:                     
Component:  Administration  |     Version:  2.2                
 Severity:  minor           |    Keywords:  frames SendToEditor
----------------------------+-----------------------------------------------
 I'd setup a WordPress blog that loads into a frame of a larger site.
 After several hours of troubleshooting javascript errors caused by the
 Send to Editor button used for adding uploaded images to a post, I found
 this simple error and corrected the issue.

 In wp-admin/upload.js: line 248
 {{{
   win = top;
 }}}

 should read
 {{{
   win = parent;
 }}}

 It really wants the parent frame and should reference it directly instead
 of the top most frame, because it's wrong to assume that top will always
 be the parent.

 The same also appears in wp-admin/inline-uploading.php: line 428
 {{{
 if (!win) win = top;
 }}}

 should read
 {{{
 if (!win) win = parent;
 }}}

 and should be changed for the same reason.

 Note: I only set it to minor because I don't think many use WordPress in a
 frame or have host that use frames for forwarding.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4586>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software