[wp-trac] Re: [WordPress Trac] #3141: explicit memory check before starting install

[WordPress Trac]

#3141: explicit memory check before starting install
-------------------------------------+--------------------------------------
 Reporter:  looksaus                 |        Owner:  ffemtcj 
     Type:  defect                   |       Status:  assigned
 Priority:  normal                   |    Milestone:  2.4     
Component:  Administration           |      Version:  2.1     
 Severity:  normal                   |   Resolution:          
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------
Comment (by darkdragon):

 Replying to both:

  1. Placing it in wp-config-sample.php would work for new installs, but
 the user would have to manually copy it wp-config.php if they already
 installed.
  1. wp-config.php is already included, therefore your statement is
 incorrect. The entire WordPress run is one process, therefore it makes no
 difference to PHP if the file is included or not.
  1. The code snippet is accurate, because you want to make sure that the
 need to increase memory is needed and then you can increase it if it is
 needed. However, you would need to place that code snippet in many
 different places that have known high memory usage. It would also be
 better to place it in a function.
  1. If the memory limit is set to >32M then you are actually
 '''lowering''' the memory limit, which is not required. You only want to
 '''raise''' the memory limit, not lower it.

 If you need a demonstration, then I can create a patch that does all of
 this.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/3141#comment:19>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software