[wp-trac] Re: [WordPress Trac] #4005: php-gettext's plural forms parsing is broken for nplurals>2

WordPress Trac wp-trac at lists.automattic.com
Fri Apr 13 08:47:53 GMT 2007


#4005: php-gettext's plural forms parsing is broken for nplurals>2
----------------------------+-----------------------------------------------
 Reporter:  moeffju         |        Owner:  ryan 
     Type:  defect          |       Status:  new  
 Priority:  high            |    Milestone:  2.2  
Component:  i18n            |      Version:  2.1.2
 Severity:  normal          |   Resolution:       
 Keywords:  has-patch i18n  |  
----------------------------+-----------------------------------------------
Changes (by nbachiyski):

  * keywords:  has-patch => has-patch i18n

Comment:

 I had some free time this morning, so here is a patch. Unfortunately one
 can't see my changes very clearly because I couldn't stand the indentation
 and fixed it before coding. Here is a summary of the changes:
  * Inside are Matthias' parenthesis fixes without the sanitizing (in
 get_plural_forms)
  * The select_string is cached in a dynamically created callback (in
 select_string)

 Anyone who sees it, please test, so we can safely put this in 2.2.

 Sewar, thanks for moving the milestone. We could have easily forgotten
 this...

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4005#comment:20>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list